feat: add code to cast #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looking good! I rebased to resolve a merge conflict, fixed some new lint errors which came up due to newer clippy versions, and also added a doc test. Thanks for the contribution, we wish to see you again :) Make sure to join the chatroom |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running both
seth code 0x00000000219ab540356cbb839cbe05303d7705faandcargo run --bin cast code --rpc-url $RPC_URL 0x00000000219ab540356cbb839cbe05303d7705faand validated that the outputs were equal via diffchecker.Feedback regarding implementation is welcome as I'm a Rust n00b and if there is more to be desired around test coverage, happy to update accordingly.