feat(anvil): enable IPC for Windows #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Dec 27, 2022
|
cross-platform tests don't run on PR but tested locally
|
|
yeh you can switch to push and it should run foundry/.github/workflows/cross-platform.yml Lines 2 to 3 in 848bb44 |
|
opened #3977 |
4 tasks
gakonst
approved these changes
Jan 3, 2023
| @@ -212,6 +212,5 @@ jobs: | |||
|
|
|||
| cross-platform: | |||
| name: Cross-platform tests | |||
| if: github.event_name != 'pull_request' | |||
There was a problem hiding this comment.
Maybe to not get spammed? I removed it just so we can test the CI here in this pr
| @@ -7,7 +7,6 @@ mod ganache; | |||
| mod gas; | |||
| mod genesis; | |||
| mod geth; | |||
| #[cfg(not(windows))] | |||
| @@ -270,10 +270,9 @@ impl NodeHandle { | |||
| } | |||
|
|
|||
| /// Connects to the ipc endpoint of the node, if spawned | |||
| #[cfg(not(windows))] | |||
|
lint failing - otherwise im open to merging as is and we can fix the windows ci separately |
mattsse
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
blocked by
gakonst/ethers-rs#1976,#3977Solution