feat(forge): add forge selectors cmd
#5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
reviewed
May 29, 2023
cli/src/cmd/forge/fourbyte.rs
Outdated
| @@ -28,6 +28,8 @@ pub struct UploadSelectorsArgs { | |||
| impl UploadSelectorsArgs { | |||
| /// Builds a contract and uploads the ABI to selector database | |||
| pub async fn run(self) -> eyre::Result<()> { | |||
| println!("Warning! This command is deprecated and will be removed in v1, use `forge selectors upload` instead"); | |||
There was a problem hiding this comment.
i think we could make this even more flashy with some yellow color, e.g: https://github.com/foundry-rs/foundry/blob/master/cli/src/cmd/forge/script/mod.rs#L750
| }; | ||
|
|
||
| #[derive(Debug, Clone, Parser)] | ||
| pub enum SelectorsSubcommands { |
There was a problem hiding this comment.
Let's leave some docs on what this is 🙏
| all: bool, | ||
|
|
||
| #[clap(flatten)] | ||
| project_paths: ProjectPathsArgs, |
There was a problem hiding this comment.
tbf I don't really know how to document this field: it doesn't look settable by the user and it's not documented over on fourbytes.rs either..
any suggestions?
There was a problem hiding this comment.
these will be flattened and will use the existing documentation
|
not sure what broke the ci - ran cargo +nightly fmt --all
cargo +nightly clippy --all --all-features -- -D warningsbefore the last commit. |
|
no worries—the ci failure is a flaky test that we need to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tackles the first part of this comment on #5012.
Solution
Ported the code from
forge upload-selectorsover toforge selectors uploadand added a warning in the former.