feat(forge): Add errors field to forge inspect
#5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jun 27, 2023
Comment on lines
+171
to
+179
| for er in abi.errors.iter().flat_map(|(_, errors)| errors) { | ||
| let types = | ||
| er.inputs.iter().map(|p| p.kind.to_string()).collect::<Vec<_>>(); | ||
| let sig = format!("{:x}", er.signature()); | ||
| let sig_trimmed = &sig[0..8]; | ||
| out.insert( | ||
| format!("{}({})", er.name, types.join(",")), | ||
| sig_trimmed.to_string().into(), | ||
| ); |
There was a problem hiding this comment.
this seems fine,
no strong opinion on the format here tbh,
defer to @Evalir
There was a problem hiding this comment.
I like this! Tested and format is the same as when printing events—looks good IMHO.
Evalir
approved these changes
Jun 27, 2023
Comment on lines
+171
to
+179
| for er in abi.errors.iter().flat_map(|(_, errors)| errors) { | ||
| let types = | ||
| er.inputs.iter().map(|p| p.kind.to_string()).collect::<Vec<_>>(); | ||
| let sig = format!("{:x}", er.signature()); | ||
| let sig_trimmed = &sig[0..8]; | ||
| out.insert( | ||
| format!("{}({})", er.name, types.join(",")), | ||
| sig_trimmed.to_string().into(), | ||
| ); |
There was a problem hiding this comment.
I like this! Tested and format is the same as when printing events—looks good IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently it is possible to get the selectors for functions (
methodIdentifiers) and events (events) but not errors.Solution
This PR adds a
errorsfield to theforge inspectcommand.