New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump cairo version in examples #2563

Draft

enitrat wants to merge 1 commit into foundry-rs:master from enitrat:chore/update-examples

+90 −85

Contributor

enitrat commented Oct 6, 2024

Introduced changes

Updates the scarb / starknet version / edition in examples
Adds required imports, removes useless imports

currently this doesn't compile because snforge test doesn't seem to be compiling contracts under default features.

Checklist

Linked relevant issue
Updated relevant documentation
Added relevant tests
Performed self-review of the code
Added changes to CHANGELOG.md - where would this go?


          chore: bump examples versions

e658251

Member

piotmag769 commented Oct 17, 2024

This should work after #2570 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cptartur Awaiting requested review from cptartur cptartur will be requested when the pull request is marked ready for review cptartur is a code owner

ddoktorski Awaiting requested review from ddoktorski ddoktorski will be requested when the pull request is marked ready for review ddoktorski is a code owner

kkawula Awaiting requested review from kkawula kkawula will be requested when the pull request is marked ready for review kkawula is a code owner

franciszekjob Awaiting requested review from franciszekjob franciszekjob will be requested when the pull request is marked ready for review franciszekjob is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet