Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get features from all targets #2570

Merged
merged 49 commits into from
Oct 30, 2024
Merged

Get features from all targets #2570

merged 49 commits into from
Oct 30, 2024

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Oct 7, 2024 •
edited
Loading

Closes #2568
Closes #2567

Introduced changes

  • Fixed features support for optimized compilation
  • Changed the starknet artifacts loading logic so they work with custom test targets.
  • Artifacts are now loaded from all test targets
  • Artifacts are now compiled to casm concurrently
  • Refactored the scarb-api crate

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

piotmag769
piotmag769 requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the logic

[nit] name_for_package is used only in a unittest, we can remove it
[nit] please move public stuff up in this file and private stuff below it, will be much easier to read

Ofc should be in a separate PR

crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
maciektr
maciektr suggested changes Oct 16, 2024
View reviewed changes
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/forge/tests/data/targets/custom_target_custom_names/metadata.json Outdated Show resolved Hide resolved
crates/forge/tests/data/targets/only_integration/Scarb.toml Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 reviewed Oct 28, 2024
View reviewed changes
crates/scarb-api/src/lib.rs Show resolved Hide resolved
crates/scarb-api/src/lib.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/deserialized.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/deserialized.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/artifacts.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/deserialized.rs Show resolved Hide resolved
crates/scarb-api/src/artifacts/representation.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/representation.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/representation.rs Outdated Show resolved Hide resolved
crates/scarb-api/src/artifacts/artifacts.rs Outdated Show resolved Hide resolved
kkawula
kkawula reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a short summary in the description of PR

crates/forge/tests/data/targets/custom_target/src/lib.cairo Outdated Show resolved Hide resolved
crates/forge/tests/data/targets/custom_target_custom_names/src/lib.cairo Outdated Show resolved Hide resolved
piotmag769
piotmag769 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, I guess the last commits were just refactors

@cptartur
Copy link
Member Author

cptartur commented Oct 30, 2024 •
edited
Loading

The docs on how this works needs to be updated in #2627

@cptartur cptartur added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 44f3196 Oct 30, 2024
25 checks passed
@cptartur cptartur deleted the 2568-get-features-from-all-targets branch October 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr requested changes

@piotmag769 piotmag769 piotmag769 approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cptartur @maciektr @piotmag769 @kkawula