From 82937a682b623bebad5d7c3e008756fdd692c76c Mon Sep 17 00:00:00 2001 From: Santiago Zarate Date: Thu, 1 Feb 2024 19:07:01 +0100 Subject: [PATCH] Be explicit about the TODO --- openqabot/types/incident.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/openqabot/types/incident.py b/openqabot/types/incident.py index bb99387..7d20323 100644 --- a/openqabot/types/incident.py +++ b/openqabot/types/incident.py @@ -186,11 +186,13 @@ def filter_failures(self, results): ] -@staticmethod +# pylint: disable=fixme # TODO: -# - move to utils -# - remove almost duplicated code from Approver.is_job_marked_acceptable_for_incident +# - move to utils.py or a better place +# - remove almost duplicated code from Approver.is_job_marked_acceptable_for_incident # as approver does not seem to operate over incidents +# about the TODO see discussion at https://github.com/openSUSE/qem-bot/pull/154#discussion_r1472721681 +@staticmethod def has_ignored_comment(job_id: int, inc: int): ret = [] ret = requests.get(OPENQA_URL + "/api/v1/jobs/%s/comments" % job_id).json()