Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XZ (LZMA) checksum repair utility #39

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Add XZ (LZMA) checksum repair utility #39

merged 6 commits into from
Jan 22, 2024

Conversation

Schamper
Copy link
Member

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d7ac7e3) 86.18% compared to head (a027734) 86.30%.

Files Patch % Lines
dissect/util/compression/xz.py 88.70% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   86.18%   86.30%   +0.12%     
==========================================
  Files          17       18       +1     
  Lines        1194     1256      +62     
==========================================
+ Hits         1029     1084      +55     
- Misses        165      172       +7
Flag Coverage Δ
unittests 86.30% <88.70%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper mentioned this pull request Jan 18, 2024
Merged
pyrco
pyrco requested changes Jan 22, 2024
View reviewed changes
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
@Schamper Schamper requested a review from pyrco January 22, 2024 11:41
pyrco
pyrco requested changes Jan 22, 2024
View reviewed changes
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
@Schamper @pyrco
Apply suggestions from code review
c6dfc6f 
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
@Schamper Schamper requested a review from pyrco January 22, 2024 15:02
pyrco
pyrco requested changes Jan 22, 2024
View reviewed changes
dissect/util/compression/xz.py Outdated Show resolved Hide resolved
@Schamper @pyrco
Update dissect/util/compression/xz.py
a027734 
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
@Schamper Schamper requested a review from pyrco January 22, 2024 15:11
@Schamper Schamper merged commit ae797dd into main Jan 22, 2024
28 checks passed
@Schamper Schamper deleted the xz-repair branch January 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrco pyrco pyrco approved these changes

@cecinestpasunepipe cecinestpasunepipe Awaiting requested review from cecinestpasunepipe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schamper @pyrco