Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter fixes on redshift schema group #43

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Linter fixes on redshift schema group #43

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4132276
Linter fixes on redshift schema group
Feb 3, 2021
1ed0165
Merge pull request #1 from raymondberg/master
raymondberg Feb 4, 2021
e1541b4
Add support for terraform 0.12
Feb 4, 2021
5ebc8c8
Improve version tooling
Feb 4, 2021
1180b37
Don't include binaries in version control
Feb 4, 2021
c4541c2
Bump to version 1.0.0
Feb 4, 2021
13d77ac
Add support for goreleaser
Feb 6, 2021
3abdfda
Add docs for publishing to the registry
Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions redshift/resource_redshift_schema_group_privilege.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func resourceRedshiftSchemaGroupPrivilegeCreate(d *schema.ResourceData, meta int
grants := validateGrants(d)
schemaGrants := validateSchemaGrants(d)

if len(grants) == 0 && len(schemaGrants) == 0 {
if len(grants) == 0 && len(schemaGrants) == 0 {
tx.Rollback()
return NewError("Must have at least 1 privilege")
}
Expand Down Expand Up @@ -203,8 +203,8 @@ func resourceRedshiftSchemaGroupPrivilegeRead(d *schema.ResourceData, meta inter

func readRedshiftSchemaGroupPrivilege(d *schema.ResourceData, tx *sql.Tx) error {
var (
usagePrivilege bool
createPrivilege bool
usagePrivilege bool
createPrivilege bool
selectPrivilege bool
updatePrivilege bool
insertPrivilege bool
Expand Down Expand Up @@ -276,7 +276,7 @@ func resourceRedshiftSchemaGroupPrivilegeUpdate(d *schema.ResourceData, meta int
grants := validateGrants(d)
schemaGrants := validateSchemaGrants(d)

if len(grants) == 0 && len(schemaGrants) == 0 {
if len(grants) == 0 && len(schemaGrants) == 0 {
tx.Rollback()
return NewError("Must have at least 1 privilege")
}
Expand Down