From 432f977685e25576e96937de7e2226b43a0eda4c Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Mon, 5 Aug 2024 17:23:48 +0530 Subject: [PATCH] fix: bank entry reference in payroll (backport #2037) (#2039) (cherry picked from commit 5fdfbbdebe29326fac2a546117fbcd137c013fb3) Co-authored-by: Rucha Mahabal --- hrms/payroll/doctype/payroll_entry/payroll_entry.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hrms/payroll/doctype/payroll_entry/payroll_entry.py b/hrms/payroll/doctype/payroll_entry/payroll_entry.py index 02d9d61faa..7a22340d11 100644 --- a/hrms/payroll/doctype/payroll_entry/payroll_entry.py +++ b/hrms/payroll/doctype/payroll_entry/payroll_entry.py @@ -918,12 +918,13 @@ def make_bank_entry(self, for_withheld_salaries=False): salary_slip_total -= salary_detail.amount + bank_entry = None if salary_slip_total > 0: remark = "withheld salaries" if for_withheld_salaries else "salaries" bank_entry = self.set_accounting_entries_for_bank_entry(salary_slip_total, remark) - if for_withheld_salaries: - link_bank_entry_in_salary_withholdings(salary_slips, bank_entry.name) + if for_withheld_salaries: + link_bank_entry_in_salary_withholdings(salary_slips, bank_entry.name) return bank_entry