From 4d3e0f57baf8992d187764b09fbf5d666400c43f Mon Sep 17 00:00:00 2001 From: Nihantra Patel Date: Mon, 28 Oct 2024 18:18:07 +0530 Subject: [PATCH] fix: update the testcase --- .../payroll_entry/test_payroll_entry.py | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py index dbc7e02805..5c846cbc3f 100644 --- a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py +++ b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py @@ -755,13 +755,27 @@ def test_loan_repayment_from_salary(self): initial_gross_pay = flt(salary_slip.gross_pay) - flt(salary_slip.total_deduction) loan_repayment_amount = flt(salary_slip.total_loan_repayment) - expected_net_pay = initial_gross_pay - loan_repayment_amount + expected_bank_entry_amount = initial_gross_pay - loan_repayment_amount payroll_entry.make_bank_entry() submit_bank_entry(payroll_entry.name) - salary_slip.reload() - self.assertEqual(salary_slip.net_pay, expected_net_pay) + bank_entry = frappe.db.sql( + """ + SELECT je.total_debit, je.total_credit + FROM `tabJournal Entry` je + INNER JOIN `tabJournal Entry Account` jea ON je.name = jea.parent + WHERE je.voucher_type = 'Bank Entry' AND jea.reference_type = 'Payroll Entry' AND jea.reference_name = %s + LIMIT 1 + """, + payroll_entry.name, + as_dict=True, + ) + + total_debit = bank_entry[0].get("total_debit", 0) + total_credit = bank_entry[0].get("total_credit", 0) + self.assertEqual(total_debit, expected_bank_entry_amount) + self.assertEqual(total_credit, expected_bank_entry_amount) def get_payroll_entry(**args):