-
Notifications
You must be signed in to change notification settings - Fork 328
Choppy audio with default output_frame_size
#204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sorry about this @vvolhejn . The I think we can just ignore the parameter and always set it to 0.2 * the output_frame_rate. |
I'm happy to open a PR for this - do you mean |
Yea that is what I am thinking thanks @vvolhejn ! |
With the default
output_frame_size
of 960, I can't get seamless audio playback from a file. This is the example I created:I run this on a .wav file. This is what I get:
Screen.Recording.2025-03-21.at.14.52.07.mov
After a hair-pulling-inducing amount of debugging, I had another look at the OpenAI example and saw that it sets
output_frame_size=480
. And voilà, using this value magically makes the playback work.Why does this happen? Is this expected behavior? In "Advanced Configuration" I found the innocent-looking note
but why is 480 not the default then? I think this should be more prominent, or there should be some kind of warning if choppy audio is detected that could be caused by the frame size...
Thank you!
The text was updated successfully, but these errors were encountered: