Ignore output_frame_size parameter #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolhejn
commented
Mar 25, 2025
| !!! tip | ||
|
|
||
| In general it is best to leave these settings untouched. In some cases, | ||
| lowering the output_frame_size can yield smoother audio playback. |
There was a problem hiding this comment.
Wasn't sure whether to keep a part of this - but it seems strange to document a parameter and then tell people not to use it
|
|
||
| ```python | ||
| from fastrtc import ReplyOnPause, Stream | ||
|
|
||
| stream = Stream( | ||
| handler=ReplyOnPause(..., output_sample_rate=24000, output_frame_size=960), | ||
| handler=ReplyOnPause(..., output_sample_rate=16000), |
There was a problem hiding this comment.
Used a non-default value so that the example actually changes the behavior. Haven't tested though.
freddyaboulton
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Thank you @vvolhejn ! And sorry for the delayed review here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #204