Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed url #13410

Closed
wants to merge 1 commit into from
Closed

changed url #13410

wants to merge 1 commit into from

Conversation

nellarro
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Changed urls on lines 1140 and 1169 from <a href="https://atjonathan.github.io/catphotoapp\ to <a href="http://freecatphotoapp.com/

@nellarro
changed url
79790dd 
lines 1140 and 1169
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 17, 2017
JosephLivengood
JosephLivengood reviewed Feb 17, 2017
View reviewed changes
seed/challenges/01-responsive-web-design/applied-visual-design.json
@@ -1137,7 +1137,7 @@
" ",
" ",
"</style>",
"<a href=\"https://atjonathan.github.io/catphotoapp\" target=\"_blank\">CatPhotoApp</a>"
"<a href=\"http://freecatphotoapp.com/" target=\"_blank\">CatPhotoApp</a>"

This comment was marked as off-topic.

Sign in to view

JosephLivengood
JosephLivengood suggested changes Feb 18, 2017
View reviewed changes
Copy link
Contributor

@JosephLivengood JosephLivengood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please enter the issue number this is fixing please!

seed/challenges/01-responsive-web-design/applied-visual-design.json
@@ -1166,7 +1166,7 @@
" ",
" ",
"</style>",
"<a href=\"https://atjonathan.github.io/catphotoapp\" target=\"_blank\">CatPhotoApp</a>"
"<a href=\"http://freecatphotoapp.com/" target=\"_blank\">CatPhotoApp</a>"

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 18, 2017
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
Open
Open
@simha95 simha95 mentioned this pull request May 14, 2022
Open
@fcsouza fcsouza mentioned this pull request May 14, 2022
Open
@bobby-lin bobby-lin mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 29, 2022
Open
@fcsouza fcsouza mentioned this pull request Oct 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephLivengood JosephLivengood JosephLivengood requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nellarro @JosephLivengood @raisedadead @BerkeleyTrue