Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: remove this mut warnings and compile errors #45

Closed
realcr opened this issue May 2, 2018 · 4 comments
Closed

help: remove this mut warnings and compile errors #45

realcr opened this issue May 2, 2018 · 4 comments
Assignees

Comments

@realcr
Copy link
Member

realcr commented May 2, 2018

I tried to compile the project with the latest Rust nightly, and got lots of strange warnings that look like this:

warning: variable does not need to be mutable
  --> src/security_module/client.rs:90:31
   |
90 |         handle.spawn(sm.then(|_| Ok(())));
   |                               ^ help: remove this `mut`

warning: variable does not need to be mutable
   --> src/security_module/client.rs:115:31
    |
115 |         handle.spawn(sm.then(|_| Ok(())));
    |                               ^ help: remove this `mut`

error: variable does not need to be mutable
   --> src/timer.rs:153:19
    |
153 |             .map(|_| tm.create_client())
    |                   ^ help: remove this `mut`

It looks like a Rust bug to me, as no mut is there.

@realcr
Copy link
Member Author

realcr commented May 2, 2018

See also:
rust-lang/rust#50343

@realcr
Copy link
Member Author

realcr commented May 3, 2018

It seems like this is related to the NLL feature. I noticed that it will take some work if we want to avoid using this feature.
Our options are to wait with this, or possibly pin to an older Rust nightly version.

@kamyuentse
Copy link
Collaborator

Currently, Niko is rewriting the borrow checker for NLL again. I pin to 04-19 nightly build, we can move forward step by step.

@realcr
Copy link
Member Author

realcr commented May 3, 2018

Cool. I'm closing this.

@realcr realcr closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants