-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release management guidelines #8
Conversation
First pass looks pretty darn good. Had some trouble verifying this step:
but that's attributable to freedomofpress/securedrop#5530, not a flaw in the docs here. Still, will want to verify that functionality prior to finalizing review. |
Marking as ready now that freedomofpress/securedrop#5520 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one teeny nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one teeny nit
42cd9c5
to
a74db7d
Compare
(Squashed into one commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving
Status
Ready for review.
This fleshes out the guide for collaborating with the Communications Manager on a release, including the preparatory steps of creating a docs PR with release-specific upgrade instructions.
It also encapsulates the one trade-off with our current branching/tagging strategy: in some cases, we may have to create a release-specific branch to ensure we don't pick up documentation changes in
main
that are not yet releasable. This is likely to be rare, but it can happen.This PR also includes a small README update to clarify that this repository is no longer in beta.