Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minnesota Attorney General Opinions #172

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

divergentdave
Copy link
Contributor

This adds a scraper for Minnesota AG opinions, per #168. This passes the tests, and the output from sample_caller looks good to me.

Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty much spot on! Can you tweak the one thing below, and I'll see if I can get this pulled and merged tomorrow?

return [opinion['summary'] for opinion in self.opinions]

def _get_precedential_statuses(self):
return ['Unpublished'] * len(self.opinions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're calling these published since I'm pretty sure no state has a distinction between published and unpublished opinions.

@mlissner mlissner merged commit 7fbe326 into freelawproject:master Feb 1, 2017
@mlissner
Copy link
Member

mlissner commented Feb 1, 2017

Thanks for this, @divergentdave ! And thanks for sending in your CLA. Makes things a lot easier in the future if we ever have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants