Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude URLs that already overlap with defaults (on first launch too) #42

Closed
fregante opened this issue Oct 18, 2022 · 0 comments · Fixed by #52
Closed

Exclude URLs that already overlap with defaults (on first launch too) #42

fregante opened this issue Oct 18, 2022 · 0 comments · Fixed by #52
Assignees
Labels

Comments

@fregante
Copy link
Owner

Extension of:

The above issue was fixed with:

excludeMatches: config.matches,

But it didn't cover injectToExistingTabs:

chrome.tabs.query({
url: origins,
}, tabs => {
for (const tab of tabs) {
if (tab.id) {
void injectContentScript(tab.id, scripts);

This is particularly visible when all_urls is granted, so it always covers all tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant