disable ffuplink-interface during initial setup - revisited #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a fresh installed system, there is no valid setup of ffuplink. So we disable this interface, till it's configured by some uplink-preset. This was cherry-picked from 29cda0a
The ffuplink interface is disabled by default on a fresh install. During the course of running the wizard, the user must select if they want to share their internet connection or not. If the user decides to share their internet, then the ffuplink interface shall be enabled (setting disabled=0). This addresses freifunk-berlin/firmware#603
pmelange
force-pushed
the
disable_ffuplink_revisited
branch
from
6ed38ed
to
1b9361a
Compare
| @@ -88,6 +88,11 @@ function main.write(self, section, value) | |||
| --share internet was not enabled before, set to false now | |||
| uci:set("ffwizard", "settings", "sharenet", "0") | |||
| uci:save("ffwizard") | |||
| --in case the wizard has been re-ran, ensure ffuplink is disabled | |||
There was a problem hiding this comment.
why are these changes made in the wireless.lua file? As it acts on the "share internet"-settings it should be better placed in "shareInternet.lua".
There was a problem hiding this comment.
shareInternet.lua is only called when the user clicks on " Am Freifunk-Netz teilnehmen und Internet teilen"
If the user clicks "Am Freifunk-Netz teilnehmen"
When the wizard is run for a second time, and if this code were in "shareInternet", and the user changes from sharing to not sharing, then the code would never run and ffuplink would not be disabled.
Sure the code could be moved to
with an else clause, but that still is not in "shareInternet". Therefore "shareInternet.lua" is not a better place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #185
In this version, the option network.ffuplink.disabled is set to 0 in the wizard if sharenet is selected. Additionally, if sharenet is disabled (for example re-running the wizard), the same option is set to 1.
Quoted from #185 (comment)
This implementation has been tested and passes the tests described in #185 (comment)