use get_attr #5
Draft
use get_attr #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aiyion.prime <git@aiyionpri.me> (cherry picked from commit 0fc770b)
|
Code is fine apparently, as tested on sn02, but the mock for the unittests has not been altered yet, which leads to them failing. |
|
Can we merge this? Right now, it is just deployed using wget. Therefore the git repo is in an unclean state and ansible refuses to work. |
|
Functionality works, unittests don't. |
lemoer
added a commit
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@1977er this is supposed to be the fix for your problem on the Mailinglist.
I have not tested this yet, maybe you call me, when you're awake to mumble this out.
0A080B8B-B322-4CC5-B268-8EF7AAFF4876 @ oliverkrueger.de