Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug type in EnergyMarketCodeType #32

Conversation

camille-bouvy-frequenz
Copy link
Contributor

The input parameter code_type of DeliveryArea was the protobuf type delivery_area_pb2.EnergyMarketCodeType.ValueType instead of the python wrapper type EnergyMarketCodeType.

@camille-bouvy-frequenz camille-bouvy-frequenz requested a review from a team as a code owner January 26, 2024 15:49
@github-actions github-actions bot added the part:docs Affects the documentation label Jan 26, 2024
Copy link
Contributor

@matthias-wende-frequenz matthias-wende-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please split the changes in two commits and add the summery in the PR also to the corresponding commit title?

The input parameter code_type of DeliveryArea was the protobuf type
delivery_area_pb2.EnergyMarketCodeType.ValueType instead of the python
wrapper type EnergyMarketCodeType.

Signed-off-by: camille-bouvy-frequenz <camille.bouvy@frequenz.com>
Signed-off-by: camille-bouvy-frequenz <camille.bouvy@frequenz.com>
@camille-bouvy-frequenz
Copy link
Contributor Author

@matthias-wende-frequenz updated 👍

@camille-bouvy-frequenz camille-bouvy-frequenz merged commit 64e0b18 into frequenz-floss:v0.x.x Jan 31, 2024
15 checks passed
@camille-bouvy-frequenz camille-bouvy-frequenz deleted the fix-bug-type branch January 31, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:docs Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants