Change edit_uri default branch to v0.x.x in mkdocs.yml #311
Conversation
github-actions
bot
added
the
part:template
|
Looks like I missed something, will have a look later. |
There was a problem hiding this comment.
Oh, the tests are actually running cookiecutter and checking the output, and the TODOs are listed there, this is why is failing. Did you use the command to update the golden tests or did you update them manually? I'm not sure if that's handled by that command.
In any case, I think the TODO should stay, maybe even more now than before, as 0.x.x is not very common at all as default branch name.
llucax
dismissed
their stale review
Missed the issue with the tests and the removed TODO
|
BTW, if this is too distracting for you, I can finish the PR myself, thanks for going straight to a PR instead of an issue! |
I did it manually.
If you can quickly fix it would be highly appreciated :) |
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com> Co-authored-by: Leandro Lucarella <luca-frequenz@llucax.com>
|
Force-merging, as I only re-generated the golden tests (and applied my own suggestion 😄 ) |
No description provided.