diff --git a/app/models/solidus_friendly_promotions/friendly_promotion_discounter.rb b/app/models/solidus_friendly_promotions/friendly_promotion_discounter.rb index ce378650..61f8fefb 100644 --- a/app/models/solidus_friendly_promotions/friendly_promotion_discounter.rb +++ b/app/models/solidus_friendly_promotions/friendly_promotion_discounter.rb @@ -10,7 +10,7 @@ def initialize(order) end def call - return nil if order.shipped? + return order if order.shipped? order.reset_current_discounts diff --git a/spec/models/solidus_friendly_promotions/friendly_promotion_discounter_spec.rb b/spec/models/solidus_friendly_promotions/friendly_promotion_discounter_spec.rb index f766f831..62c2de49 100644 --- a/spec/models/solidus_friendly_promotions/friendly_promotion_discounter_spec.rb +++ b/spec/models/solidus_friendly_promotions/friendly_promotion_discounter_spec.rb @@ -8,8 +8,9 @@ subject { described_class.new(order).call } - it "returns nil" do - expect(subject).to be nil + it "returns the order unmodified" do + expect(order).not_to receive(:reset_current_discounts) + expect(subject).to eq(order) end end end