David dual boot #1104
David dual boot #1104
Conversation
- This allows to try the next Rails version with existing dependencies.
- Sets required on both tool and user
| user = create(:user) | ||
| attributes = { | ||
| user_id: user.id, | ||
| purpose: "To build a house", |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
|
|
||
| trait :other do | ||
| semester Post::OTHER | ||
| semester {Post::OTHER} |
There was a problem hiding this comment.
Layout/SpaceInsideBlockBraces: Space missing inside {.
Layout/SpaceInsideBlockBraces: Space missing inside }.
| end | ||
|
|
||
| trait :spring do | ||
| semester Post::SPRING | ||
| semester {Post::SPRING} |
There was a problem hiding this comment.
Layout/SpaceInsideBlockBraces: Space missing inside {.
Layout/SpaceInsideBlockBraces: Space missing inside }.
| if next? | ||
| gem 'rails', '~> 5.2' | ||
| else | ||
| gem 'rails', '5.1.6.2' |
There was a problem hiding this comment.
Bundler/DuplicatedGem: Gem rails requirements already given on line 11 of the Gemfile.
| @@ -1,10 +1,19 @@ | |||
| def next? | |||
| File.basename(__FILE__) == "Gemfile.next" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -3,7 +3,7 @@ class Admin::CouncilsController < Admin::BaseController | |||
| load_permissions_and_authorize_resource find_by: :url | |||
|
|
|||
| def index | |||
| @council_grid = initialize_grid(Council, locale: :sv, order: 'council_translations.title') | |||
| @council_grid = initialize_grid(Council.with_translations(I18n.locale), order: 'council_translations.title') | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [112/110]
|
Stänger den här innan #1107 är klar. |
Hej från en gammal och dryg!
Denna PR lägger till en extra Gemfile.lock, som kan användas för att testa nästa Rails-version för att se vilka dependencies som behöver uppdateras.
Fixade också lite andra små grejer som gjorde att testerna inte körde lokalt för mig.
Skulle säkert vara bra att testa på stage först.