Update FS-1079-union-properties-visible => members to be created even when union has signature files #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click “Files changed” → “⋯” → “View file” for the rendered RFC.
After the implementation of FS-1079 was merged in, @KevinRansom and I independently observed a failure in the compiler codebase when using a freshly built compiler with preview features on.
Important to note, this FS-1079 was not actively used anywhere.
What happened is that unpickling metadata from the built Fsharp.Compiler.Service.dll failed when encountering a combination of:
The usage of that type from a different type meant using type information from the signature file.
The resulting error was a general unpickling failure (".. error at node 6652") which only after rebuilding the compiler from scratch lead to the discovery of a union in module rec in .fsi undere that ID.
I believe the fix in dotnet/fsharp#16657 is good, but we must acknowledge that the .fsi files will now expose the .Is* testers even for F# consumers, not just on IL level.