Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposal is not called with use! and the like #157

Closed
abelbraaksma opened this issue Jun 2, 2023 · 1 comment · Fixed by #149
Closed

Disposal is not called with use! and the like #157

abelbraaksma opened this issue Jun 2, 2023 · 1 comment · Fixed by #149
Labels
bug Something isn't working topic: taskseq-ce Related to the taskseq computation expression builders or overloads
Milestone
v0.4.0-alpha.1

Comments

@abelbraaksma
Copy link
Member

abelbraaksma commented Jun 2, 2023 •
edited
Loading

It appears that Dispose() or DisposeAsync() is not being called when use! is used. First mentioned offline by @bartelink. Logging here to link the PR to a tracking issue and for the changelog/release notes.

Turned out that this was inadvertently commented out in 27486f3, which shouldn't have happened. In a follow up I will create some tests to ensure this won't happen again.
@abelbraaksma abelbraaksma mentioned this issue Jun 2, 2023
Merged
@abelbraaksma
Copy link
Member Author

abelbraaksma commented Jun 2, 2023 •
edited
Loading

This will be fixed in #149 and deployed as an interim release as 0.4.0 alpha. I'll release tomorrow (#159).

@abelbraaksma abelbraaksma mentioned this issue Jun 5, 2023
Closed
@abelbraaksma abelbraaksma added bug Something isn't working topic: taskseq-ce Related to the taskseq computation expression builders or overloads labels Oct 29, 2023
@abelbraaksma abelbraaksma mentioned this issue Mar 17, 2024
Merged
@abelbraaksma abelbraaksma added this to the v0.4.0-alpha.1 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working topic: taskseq-ce Related to the taskseq computation expression builders or overloads
Projects
None yet
Milestone
v0.4.0-alpha.1
Development

Successfully merging a pull request may close this issue.

Reinstate Disposal bartelink/FSharp.Control.TaskSeq
1 participant
@abelbraaksma