Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some oddly named utility functions and replace with more sensible naming, deprecate type taskSeq<_> for TaskSeq<_> #193

Closed
abelbraaksma opened this issue Nov 5, 2023 · 0 comments · Fixed by #194
Closed

Deprecate some oddly named utility functions and replace with more sensible naming, deprecate type taskSeq<_> for TaskSeq<_> #193

abelbraaksma opened this issue Nov 5, 2023 · 0 comments · Fixed by #194
Labels
compatibility Related to backward or forwards, or F# Core or .NET version compatibility topic: surface area Adds functions to the public surface area
Milestone
v0.4.0

Comments

@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 5, 2023 •
edited
Loading

I'm talking of these two:

  • ValueTask.ofIValueTaskSource -> ValueTask.ofSource
  • ValueTask.FromResult -> ValueTask.fromResult

And we want to use proper naming for our types (PascalCase for the type, camelCase for the CE builder), so the type taskSeq<_> will be changed to TaskSeq<_>. This has already been done in #187.
@abelbraaksma abelbraaksma changed the title Deprecate some oddly named utility functions and replace with more sensible naming Deprecate some oddly named utility functions and replace with more sensible naming, deprecate type taskSeq<_> for TaskSeq<_> Nov 5, 2023
@abelbraaksma abelbraaksma mentioned this issue Nov 5, 2023
Merged
@abelbraaksma abelbraaksma added topic: surface area Adds functions to the public surface area compatibility Related to backward or forwards, or F# Core or .NET version compatibility labels Nov 5, 2023
@abelbraaksma abelbraaksma mentioned this issue Nov 5, 2023
Merged
@abelbraaksma abelbraaksma mentioned this issue Mar 17, 2024
Merged
@abelbraaksma abelbraaksma added this to the v0.4.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Related to backward or forwards, or F# Core or .NET version compatibility topic: surface area Adds functions to the public surface area
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Deprecate minor utility functions fsprojects/FSharp.Control.TaskSeq
1 participant
@abelbraaksma