Fix resumability of iteration over `IAsyncEnumerable<'T>`#42

Merged

abelbraaksma merged 27 commits intomainfrom fix-resumability-of-iteration

Oct 28, 2022

+1,211-42

Commits on Oct 26, 2022

Add a bunch of multiple iteration tests
abelbraaksma
committed
Adding several comments and log statements to get to the bottom of this, partially fixed
abelbraaksma
committed
Issue #39 , adding bunch of tests that show various ways of getting InvalidState exceptions
abelbraaksma
committed
Add (failing) tests for calling IAsyncEnumerator.Current *before* iteration starts
abelbraaksma
committed
Fix: do not throw an exception on IAsyncEnumerator.Current when undefined, instead return default value for type
abelbraaksma
committed
Add (currently failing) tests for transitioning state to *after* sequence is completed
abelbraaksma
committed
Fix tests, Fact vs Theory
abelbraaksma
committed
Fix: ensure Current returns Unchecked.defaultof when *beyond* the end of the async stream
abelbraaksma
committed
Improve verbosity printing
abelbraaksma
committed
Record whether or not the IAsyncEnumerable is "past completion", which solves calling MoveNextAsync() multiple times after completion and removes the InvalidStateException
abelbraaksma
committed
Make the test's code a little more readable
abelbraaksma
committed
Add two tests the show the difference in behavior between two seq processed in lock step, or individually to completion
abelbraaksma
committed
Renaming 'this' pointer for clarity, ts -> this.
abelbraaksma
committed
Initialize new TaskSeqStateMachineData() when getting a new enumerator
abelbraaksma
committed
Add test for basic case of incorrect MoveNext state after creating new Enumerator, after a full loop through all items
abelbraaksma
committed
Fix incorrect ResumptionPoint resume by force-resetting the Machine in the builder
abelbraaksma
committed
Add a (failing) test to investigate Faulted state with multiple iterators when tasks are yielded, instead of concrete
abelbraaksma
committed
Adding a bunch of variants with delayed yields to check proper state transition
abelbraaksma
committed
Disable a bunch of tests, and set verbose=false, as CI cannot deal with large logs
abelbraaksma
committed
Fix rebase mistake
abelbraaksma
committed
Temp disable worrisome tests to get xUnit to complete in CI
abelbraaksma
committed
Show that the NRE can also occur in synchronous versions of taskSeq
abelbraaksma
committed
Add two more tests, and improve logging
abelbraaksma
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix resumability of iteration over `IAsyncEnumerable<'T>`#42

Commits on Oct 26, 2022

Add a bunch of multiple iteration tests

Adding several comments and log statements to get to the bottom of this, partially fixed

Issue #39 , adding bunch of tests that show various ways of getting InvalidState exceptions

Add (failing) tests for calling IAsyncEnumerator.Current before iteration starts

Fix: do not throw an exception on IAsyncEnumerator.Current when undefined, instead return default value for type

Add (currently failing) tests for transitioning state to after sequence is completed

Fix tests, Fact vs Theory

Fix: ensure Current returns Unchecked.defaultof when beyond the end of the async stream

Improve verbosity printing

Record whether or not the IAsyncEnumerable is "past completion", which solves calling MoveNextAsync() multiple times after completion and removes the InvalidStateException

Make the test's code a little more readable

Add two tests the show the difference in behavior between two seq processed in lock step, or individually to completion

Renaming 'this' pointer for clarity, ts -> this.

Initialize new TaskSeqStateMachineData() when getting a new enumerator

Add test for basic case of incorrect MoveNext state after creating new Enumerator, after a full loop through all items

Fix incorrect ResumptionPoint resume by force-resetting the `Machine` in the builder

Add a (failing) test to investigate Faulted state with multiple iterators when tasks are yielded, instead of concrete

Adding a bunch of variants with delayed yields to check proper state transition

Disable a bunch of tests, and set verbose=false, as CI cannot deal with large logs

Fix rebase mistake

Temp disable worrisome tests to get xUnit to complete in CI

Show that the NRE can also occur in synchronous versions of taskSeq

Add two more tests, and improve logging

Commits on Oct 28, 2022

use copy of initial state machine to get resumption back to zero

Cleanup TaskSeqBuilder now that we have a working version (credits @dsyme )

Fix expected test output and ignore a test that's dependent on faulty input

Re-enable previously hanging and crashing tests, add extra, more complex, mutable state scenario