Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interoperating with existing F# async #79

Closed
dsyme opened this issue Nov 5, 2022 · 2 comments · Fixed by #114
Closed

Interoperating with existing F# async #79

dsyme opened this issue Nov 5, 2022 · 2 comments · Fixed by #114
Assignees
@abelbraaksma
Labels
feature request New feature or enhancement request topic: taskseq-ce Related to the taskseq computation expression builders or overloads
Milestone
v0.4.0-alpha.1

Comments

@dsyme
Copy link
Contributor

dsyme commented Nov 5, 2022

We could allow binding to an existing F# Async, passing the cancellation token through.

Similar to this in the existing AsyncSeq: https://github.com/fsprojects/FSharp.Control.AsyncSeq/blob/main/src/FSharp.Control.AsyncSeq/AsyncSeq.fs#L425
@abelbraaksma abelbraaksma added feature request New feature or enhancement request topic: taskseq-ce Related to the taskseq computation expression builders or overloads labels Nov 6, 2022
This was referenced Nov 27, 2022
Closed
Merged
@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 28, 2022 •
edited
Loading

See #114 for a first attempt at this.

@abelbraaksma abelbraaksma self-assigned this Nov 30, 2022
@abelbraaksma
Copy link
Member

abelbraaksma commented Dec 18, 2022 •
edited
Loading

This has now been implemented and will be part of the 0.4.0 release cycle.

Cancellation token passing in the general sense is still up for discussion, see #133, /cc @dsyme.

@abelbraaksma abelbraaksma mentioned this issue Jun 5, 2023
Closed
@abelbraaksma abelbraaksma mentioned this issue Mar 17, 2024
Merged
@abelbraaksma abelbraaksma modified the milestones: v0.4.0-alpha.1, v0.3.0 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelbraaksma abelbraaksma

Labels
feature request New feature or enhancement request topic: taskseq-ce Related to the taskseq computation expression builders or overloads
Projects
None yet
Milestone
v0.4.0-alpha.1
Development

Successfully merging a pull request may close this issue.

Add let! and do! support for F# async / Async<'T> fsprojects/FSharp.Control.TaskSeq
2 participants
@dsyme @abelbraaksma