Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New typePrefixing modes "Always" and "Never" (default: "Hybrid") #661

Merged
merged 17 commits into from
Jan 9, 2024
Merged

New typePrefixing modes "Always" and "Never" (default: "Hybrid") #661

merged 17 commits into from
Jan 9, 2024

Commits on Dec 30, 2023

  1. tests/Console: rename some vars with confusing names

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    746b001 View commit details
    Browse the repository at this point in the history

  2. tests/Console: regression test for typePrefixing 

    As we're going to change how the configuration of this rule is
structured, we first create a test to make sure the old config
works.
    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    99a6642 View commit details
    Browse the repository at this point in the history

  3. sln: add docs (to edit rules info in IDE)

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    a7a36e2 View commit details
    Browse the repository at this point in the history

  4. docs(rule10): fix typo [no ci]

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    310b7b0 View commit details
    Browse the repository at this point in the history

  5. fsharplint.json: fix cosmetic double-space

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    3108e36 View commit details
    Browse the repository at this point in the history

  6. Core.{Rules,Tests},docs: prepare for TypePrefixing new cfg

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    a487776 View commit details
    Browse the repository at this point in the history

  7. tests(TypePrefixing): 1st two tests for Always mode (should pass alre… 

    …ady)

The 'Always' mode behaves in the same way for this case.
    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    6957536 View commit details
    Browse the repository at this point in the history

  8. tests(TypePrefixing): add 2 failing tests for Always cfg

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    1e474d3 View commit details
    Browse the repository at this point in the history

  9. TypePrefixing(Always): make tests pass

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    0264faf View commit details
    Browse the repository at this point in the history

  10. tests(TypePrefixing): 1st Never Mode tests (should pass already)

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    c6c0488 View commit details
    Browse the repository at this point in the history

  11. tests(TypePrefixing): 2 failing tests for Never mode

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    2fc75d8 View commit details
    Browse the repository at this point in the history

  12. TypePrefixing: make Never tests pass

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    2375096 View commit details
    Browse the repository at this point in the history

  13. tests(TypePrefixing): 2 failing tests for array(Always) 

    Also editing an existing Hybrid mode one to make sure we
don't break it.
    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    18f9f96 View commit details
    Browse the repository at this point in the history

  14. TypePrefixing: make new Always array tests pass

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    3e1d4d7 View commit details
    Browse the repository at this point in the history

  15. tests(TypePrefixing): failing test for [] in Always mode

    @knocte
    knocte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    9e62473 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. TypePrefixing: make new Always array test pass 

    Handle case of array types like `foo[]` in Always mode.
    @webwarrior-ws
    webwarrior-ws committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5e68892 View commit details
    Browse the repository at this point in the history

  2. Configuration,Tests.Console: re-enabled regression test 

    Re-enabled regression test for TypePrefixing rule with old
config format and made it pass.
    @webwarrior-ws
    webwarrior-ws committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e3ea85b View commit details
    Browse the repository at this point in the history