Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix License information and packing the sample files. #176

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

CaptnCodr
Copy link
Member

@CaptnCodr CaptnCodr commented Nov 5, 2020

While packing the nuget packages using dotnet paket pack ... the following warnings appeared:
image
After that I downloaded the sample packages, depacked them and found no content in it.

Click on "License Info" refers to "https://github.com/fsprojects/FsUnit/blob/master/LICENSE.txt" but it's "license.txt":

image

@sergey-tihon
Copy link
Member

Is it show the same warn if you use NuGet target from FAKE script?
https://github.com/fsprojects/FsUnit/blob/master/build.fsx#L184

@CaptnCodr
Copy link
Member Author

Yes, it is:
image

The content of the sample packages are only the "*.nuspec", a "[Content_Types].xml" and "package\services\metadata\core-properties\coreProp.psmdcp"

With this fix we have another folder "content\netstandard2.0" with FsUnitSample.fs.pp in it.

@sergey-tihon
Copy link
Member

Got it, thanks. Feel free to merge it when it is done

@CaptnCodr
Copy link
Member Author

For sure.

And releasing it as 4.0.2 to have the packages deployed properly?

Will merge it tonight.

@CaptnCodr CaptnCodr merged commit 0249d29 into fsprojects:master Nov 7, 2020
@CaptnCodr CaptnCodr deleted the bugfix/PaketTemplates branch November 7, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants