-
Notifications
You must be signed in to change notification settings - Fork 162
Add **kwargs parameters to _mkdir, _cat_file, adhere to fsspec API #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wouldn't it be better if we actually supported |
|
I think this PR is more about adhering to the fsspec API for forward compatibility. If creating an empty bucket is desired behavior for this API, this should probably be addressed in a different PR. |
|
|
|
The problem is that it is indeed part of the fsspec API: https://github.com/fsspec/filesystem_spec/blob/master/fsspec/asyn.py#L737-L738 but is not implemented in gcsfs: https://github.com/fsspec/gcsfs/blob/main/gcsfs/core.py#L606-L611 (and |
|
Right, so instead of ignoring it with **kwargs, I am suggesting that now would be a good time to implement it - right in this PR. |
|
I'm not familiar with gcs internals/API, so if someone would like to add to this PR, please go ahead. |
|
Or is it literally just removing these two lines if |
|
How about that? |
|
Thanks! |
`gcsfs` complains about an invalid `create_parents` argument when using google cloud storage with cloud checkpoints. Thus we should use an alternative fs spec handler that omits this argument for gs. The root issue will be fixed here: fsspec/gcsfs#471
These two methods don't accept
**kwargsparameters, which makes them incompatible with libraries utilizing the abstract API. For example, pyarrow 6.0.1 fails for create dir:with
Closes #404