Skip to content

Conversation

@mannreis
Copy link
Contributor

Faced some issues when using virtualizarr because of this

@martindurant
Copy link
Member

If you have a link to an issue on vzarr, would appreciate including it here

@martindurant
Copy link
Member

Tests appear broken by recent zarr release, which requires type to go Object->str in HDF. Would you have time to find and fix this?

@mannreis
Copy link
Contributor Author

I don't have any open issue in virtualizarr nor here. I hot patched by environment so that my scripts don't fail when loading old netcdf datasets with non utf-8 encoded attributes.

I managed to reproduce the problem locally but by upgrading zarr to 3.0.10 the issue goes away

@martindurant
Copy link
Member

I managed to reproduce the problem locally but by upgrading zarr to 3.0.10 the issue goes away

!!

So actually he only thing that's wrong here is the failing tests. I'll merge this and try to fix it, although this week is rammed.

@martindurant
Copy link
Member

You are right, things appear to pass with release 3.0.10, but not with the main branch (which gives version 3.0.9+devXX). I wonder what is going on!

@mannreis
Copy link
Contributor Author

In the meantime the zarr-python/main version is 3.1.0 so there's a change retriggering the tests will make them pass @martindurant.

I've opened #567 as side follow up on this testing debugging. Feel free to close it if it's not really desired to tests against a "stable" zarr release

@martindurant
Copy link
Member

Now pulls zarr 3.1.0, but still fails :\ . Did you say (in the other PR) that you saw this pass?

@mannreis
Copy link
Contributor Author

I checked now and with 3.1.0 it will fail!

@martindurant
Copy link
Member

...but it just passed! I am so confused.

Do you happen to know what PRs in zarr are implicated?

@martindurant martindurant merged commit 161eeed into fsspec:main Jul 16, 2025
4 checks passed
@mannreis
Copy link
Contributor Author

mannreis commented Jul 17, 2025

@martin I just saw zarr-developers/VirtualiZarr#676 which seems to track what we saw here but in virtualizarr. In a way it was good to revert #567 I don't have time to dive deeper into the issue but I could help reviewing or testing any changes here.

@mannreis mannreis deleted the patch-1 branch July 17, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants