-
Notifications
You must be signed in to change notification settings - Fork 95
Ignore errors when decoding attributes in netCDF3.py #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you have a link to an issue on vzarr, would appreciate including it here |
|
Tests appear broken by recent zarr release, which requires type to go Object->str in HDF. Would you have time to find and fix this? |
|
I don't have any open issue in virtualizarr nor here. I hot patched by environment so that my scripts don't fail when loading old netcdf datasets with non utf-8 encoded attributes. I managed to reproduce the problem locally but by upgrading |
!! So actually he only thing that's wrong here is the failing tests. I'll merge this and try to fix it, although this week is rammed. |
|
You are right, things appear to pass with release 3.0.10, but not with the |
|
In the meantime the I've opened #567 as side follow up on this testing debugging. Feel free to close it if it's not really desired to tests against a "stable" zarr release |
|
Now pulls zarr 3.1.0, but still fails :\ . Did you say (in the other PR) that you saw this pass? |
|
I checked now and with |
|
...but it just passed! I am so confused. Do you happen to know what PRs in zarr are implicated? |
|
@martin I just saw zarr-developers/VirtualiZarr#676 which seems to track what we saw here but in |
Faced some issues when using virtualizarr because of this