-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various small changes #42
Conversation
mrocklin
commented
May 13, 2016
- Create a directory for mapping if it doesn't exist.
- Include original exception error messages
S3 keys don't really need a "directory key" to live within. The empty key wouldn't hurt, I suppose. |
The problem is with recursive rm: if there are not actually any files below to pass to bulk_delete. |
I ran into this when creating a mapping from a non-existent bucket, in which case the mkdir does become necessary (I think). |
Ah, so it's not the directory you want to create per se, but the bucket for it to live within. I'm not sure we should do that automatically. |
What would you recommend? Improved error message? |
Error message I think, yes. Either happens at check time or on first write when |
Thoughts on adding a |
OK, fine with me. The whole mapping thing of course is for zarr's convenience. Most users of s3fs itself probably won't touch it. |