Fix missing mut in Mat4::as_mut_array #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fu5ha
approved these changes
Sep 3, 2023
|
Sure, I'll do one now :) This is a breaking change of the api, buuuuuut the fact hat it was clearly wrong and you're the first person to report it suggests to me nobody else has used it, so I think I'll cheat and get it into a patch version anyway |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again, this is a typo fix to make the output of
Mat4::as_mut_arraymutatable, to match the other matrix sizes.If you have time to take a look for the next update then that would be awesome, thanks!