Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button for workflows shows incorrect error message #295

Closed
LeStegii opened this issue Nov 29, 2022 · 0 comments · Fixed by #296
Closed

Download button for workflows shows incorrect error message #295

LeStegii opened this issue Nov 29, 2022 · 0 comments · Fixed by #296
Assignees
Labels
bug Something isn't working
Milestone

Comments

@LeStegii
Copy link
Contributor

Possibly related to this issue.

Describe the bug
The following report is not really about an error/a bug, but rather an inaccurate error message.

If you disable local storage in the privacy settings, create a workflow using fulibWorkflows and try to download any type of output, it prints out an error into the little toast in the upper right corner. The error says: "Download Files - Editor Content does not exist". It doesn't matter what types of outputs are selected.

This is caused by yamlContent in download-es.component.ts being null everytime, as it can only get its data from the privacyService if the allowLocalStorage() method returns true (which isn't the case if local storage is disabled).

While this is not an error/a bug, the message displayed suggests that something went wrong and the content doesn't exist. Instead something like "Could not download files - Please allow the use of local data storage in your Privacy Preferences." should be displayed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://fulib.org/workflows and disable local storage in the privacy settings.
  2. Create a new workflow (for example just - workflow: Example).
  3. Press 'Download'.
  4. See inaccurate error.

Expected behavior
A more precise error should be displayed.

Screenshots
If applicable, add screenshots to help explain your problem.
grafik

Desktop (please complete the following information):

  • OS: Windows
  • FireFox
  • Windows 10 (64-Bit), FireFox 107.0 (64-Bit)

Additional context
It appears that this has happened to multiple users and since the error is not providing any information, they weren't able to find the cause.

@LeStegii LeStegii added the bug Something isn't working label Nov 29, 2022
@Clashsoft Clashsoft added this to the v1.13.1 milestone Dec 21, 2022
@Clashsoft Clashsoft self-assigned this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants