Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guzzle by Symfony HttpClient #2

Open
JorisCourtois-fulll opened this issue May 16, 2024 · 0 comments
Open

Replace Guzzle by Symfony HttpClient #2

JorisCourtois-fulll opened this issue May 16, 2024 · 0 comments
Labels
back maintenance

Comments

@JorisCourtois-fulll
Copy link

Transform hapiclient-php-guzzle7 into hapiclient-symfony.

HapiClient\Http\HapiClient.php

  • Replace usage GuzzleHttp\Client by Symfony\Contracts\HttpClient\HttpClientInterface
  • Remove usage of \GuzzleHttp\Psr7\Request, use HapiClient\Http\Request ( no need of \GuzzleHttp\Psr7\Utils::streamFor($body) as HttpClient already streams the body)

Bonus

Find a replacement for GuzzleHttp\UriTemplate\UriTemplate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JorisCourtois-fulll