Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngx-meta/core Doesn't support Angular 11.X.X #210

Closed
Heatmanofurioso opened this issue Nov 19, 2020 · 11 comments
Closed

@ngx-meta/core Doesn't support Angular 11.X.X #210

Heatmanofurioso opened this issue Nov 19, 2020 · 11 comments

Comments

@Heatmanofurioso
Copy link

I'm submitting a ...

[x] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->

Current behavior
Currently we can't update Angular projects to 11.x.x using ng update, which also contain @ngx-meta/core due to @ngx-meta/core only supporting up until 10.0.0

Expected/desired behavior
@ngx-meta/core should be able to support Angular 11.x.x

Minimal reproduction of the problem with instructions
Any Angular project in 10.x.x, and attempting to perform ng update @angular/core

What is the motivation / use case for changing the behavior?
Keeping up with current versions of Angular and keeping the package alive and relevant with current developments

Environment

  • Angular version: 11.0.1

  • For Tooling issues:

  • Node version: 12.18.4
  • Platform: Windows 10 Professional Edition
@MaxKless
Copy link

I'm facing the same issue, any info on this?

@matusbielik
Copy link

@fulls1z3 is this library still developed?

@matusbielik
Copy link

matusbielik commented Feb 17, 2021

@fulls1z3 asking again... Are there any plans to continue development or at least supporting this library for new Angular versions?
I was able to upgrade it to work for Ng10 locally, but because of actual permissions, I can't push the branch to remote to make PR, therefore it is not possible to follow contributions guidelines for this repo.

ngx-meta git:(ng-v10-upgrade) git push remote: Permission to fulls1z3/ngx-meta.git denied to matusbielik. fatal: unable to access 'https://github.com/fulls1z3/ngx-meta.git/': The requested URL returned error: 403

Can you please provide any statement on this? Or should we forsake this library for good?

@Heatmanofurioso
Copy link
Author

Considering the library has been "abandoned/deprecated".
I suggest simply utilizing Angular's Meta components @matusbielik

@aaa123eee
Copy link

Yeah, now it's better to use @angular/platform-browser

@matusbielik
Copy link

@aaa123eee @Heatmanofurioso this library uses meta service from @angular/platform-browser under the hood, so I wouldn't say that using Meta service is 'better' per se.
@ngx-meta has a few usable capabilities that we find valuable, like MetaGuard, this way we can set title and meta tags in routes file.

As this library seems to be abandoned and the author doesn't even bother to answer questions about its future (but is still active on github in private repos), I decided to get rid of all the ngx-* libraries and implement the functionality myself.

@Heatmanofurioso
Copy link
Author

@matusbielik You are correct, although I think Angular's Meta allows you to do that too by itself nowadays.
My main reason to drop the library is really how it seems to have been abandoned too.

It's a pity, as it really is a good project

@yangjunfocus
Copy link

I'm facing the same issue, any info on this?

ArtemDintecom added a commit to dintecom/ngx-meta that referenced this issue Jun 3, 2021
BREAKING CHANGE: Support only Angular 12
@Volen99
Copy link

Volen99 commented Jun 3, 2021

Same issue here :(

@Volen99
Copy link

Volen99 commented Jun 3, 2021

Guys!! Peertube have been using ngx-meta, but now that it is no longer supported, they have deleted it and made their own guard here: https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/core/routing/meta-guard.service.ts
and use it like this, e.g.

path: 'about',
loadChildren: () => import('./+about/about.module').then(m => m.AboutModule),
canActivateChild: [ MetaGuard ]

link: https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/app-routing.module.ts

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

@fulls1z3 fulls1z3 closed this as completed Jul 8, 2021
ArtemDintecom added a commit to dintecom/ngx-meta that referenced this issue Apr 18, 2022
ArtemDintecom added a commit to dintecom/ngx-meta that referenced this issue Jun 8, 2022
ArtemDintecom added a commit to dintecom/ngx-meta that referenced this issue Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants