-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use universal methods to manipulate the HTML element #32
Comments
They did miss that one.. I'm setting it after rendering the HTML for now |
I think I know why they missed that one. It is simply not within the scope of title.service and meta.service. On the other hand, I could develop a method to do it by using the Seems like I'll need to develop and integrate it into Angular and make a PR. With the next release of Angular, the |
I'm submitting a ... (check one with "x")
Current behavior
In @nglibs/meta v0.2.0-rc.5, manipulating the HTML element (to set the lang attribute) has been commented out, in scope of preventing direct DOM manipulation.
Expected/desired behavior
We need to set the lang attribute of HTML element, using universal methods as they become available.
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Please tell us about your environment:
Language: [all | TypeScript X.X | ES6/7 | ES5]
Node (for AoT issues):
node --version
=The text was updated successfully, but these errors were encountered: