Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated setuptools versions #268

Merged
merged 1 commit into from
Oct 9, 2022
Merged

updated setuptools versions #268

merged 1 commit into from
Oct 9, 2022

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Oct 8, 2022

just updating the build tool versions

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #268 (f52fe29) into develop (cde27f0) will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #268      +/-   ##
===========================================
+ Coverage    96.33%   96.48%   +0.15%     
===========================================
  Files           81       82       +1     
  Lines         5432     5523      +91     
===========================================
+ Hits          5233     5329      +96     
+ Misses         199      194       -5     
Impacted Files Coverage Δ
paramak/__init__.py 94.50% <0.00%> (ø)
paramak/shape.py 97.41% <0.00%> (+0.34%) ⬆️
paramak/utils.py 94.87% <0.00%> (+2.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shimwell
Copy link
Member Author

shimwell commented Oct 9, 2022

Failing on unrelated error

test_shape_1 = paramak.DishedVacuumVessel(rotation_angle=180)
test_shape_2 = paramak.DishedVacuumVessel(rotation_angle=360)

  assert test_shape_1.volume() * 2 == pytest.approx(test_shape_2.volume())

E assert 0.0 == 21536838.298035033 ± 2.2e+01
E comparison failed
E Obtained: 0.0
E Expected: 21536838.298035033 ± 2.2e+01

@shimwell shimwell merged commit 0344d95 into develop Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant