Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer working with Node.js 10 #2

Closed
VanCoding opened this issue Apr 28, 2018 · 1 comment
Closed

No longer working with Node.js 10 #2

VanCoding opened this issue Apr 28, 2018 · 1 comment

Comments

@VanCoding
Copy link
Contributor

Sadly, when running this with Node.js 10, buffer.readUIntLE(offset, 8) throws an exception about only accepting byte lengths up to 6.

I don't know the reason for this change, but it's probably to make sure that there are no overflows because JavaScript does not support int64 values.

But since this was never a problem before, I think it's safe work around this instead of switching an int64 library.
@VanCoding VanCoding mentioned this issue Apr 30, 2018
Merged
@futomi
Copy link
Owner

futomi commented Jun 9, 2018

Sorry to be late. Thank you for your feedback.
Today, I'll try to support Node.js 10.

@futomi futomi closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VanCoding @futomi