Skip to content
This repository has been archived by the owner on Jun 5, 2021. It is now read-only.

Commit

Permalink
Fix path to dev_server_options.js (#39)
Browse files Browse the repository at this point in the history
This should fix #37.

There seems to be an issue remaining where, if node_modules is present locally (because user ran `yarn install` for example), the wrong version of webpack-dev-server is used.
  • Loading branch information
fwouts authored Jan 8, 2019
1 parent adbd49e commit 1c8b9ca
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion internal/web_bundle/rule.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ server.listen(port, 'localhost', function (err) {{
internal_packages_dir = ctx.attr._internal_packages[NpmPackagesInfo].installed_dir.short_path,
# Template index.html for Webpack.
html_template = ctx.file.html_template.short_path if ctx.file.html_template else "",
dev_server_options = ctx.attr.lib[JsLibraryInfo].compiled_javascript_dir.short_path + "/" + ctx.file.dev_server_options.short_path,
dev_server_options = ctx.file.dev_server_options.short_path,
),
)
ctx.actions.write(
Expand All @@ -180,6 +180,7 @@ server.listen(port, 'localhost', function (err) {{
executable = ctx.outputs.devserver,
runfiles = ctx.runfiles(
files = [
ctx.file.dev_server_options,
ctx.file._internal_nodejs,
ctx.file._web_bundle_compile_script,
webpack_devserver_js,
Expand Down

0 comments on commit 1c8b9ca

Please sign in to comment.