From 737670503be9ae3e9dbf4e60a1de8e4cdf3abccd Mon Sep 17 00:00:00 2001 From: Steven Sacks Date: Wed, 18 Sep 2024 02:22:11 +0900 Subject: [PATCH 1/2] ci: remove storybook build step --- .github/workflows/chromatic.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml index 494dca8..3455be9 100644 --- a/.github/workflows/chromatic.yml +++ b/.github/workflows/chromatic.yml @@ -26,16 +26,6 @@ jobs: - name: get-npm-version id: package-version uses: martinbeentjes/npm-get-version-action@v1.3.1 - - name: Build Storybook - run: npm run build-storybook - env: - SB: 1 - API_URL: ${{ secrets.API_URL }} - COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }} - MSW_ENABLED: ${{ secrets.MSW_ENABLED }} - npm_package_version: ${{ steps.package-version.outputs.current-version}} - SESSION_SECRET: ${{ secrets.SESSION_SECRET }} - SITE_URL: ${{ secrets.SITE_URL }} - name: Run Chromatic uses: chromaui/action@latest with: @@ -44,7 +34,6 @@ jobs: debug: true exitZeroOnChanges: true exitOnceUploaded: true - storybookBuildDir: 'storybook-static' autoAcceptChanges: 'main' onlyChanged: true externals: 'app/styles/tailwind.css' From 642be04f24be2af79494889bc67f99ed267d8fa5 Mon Sep 17 00:00:00 2001 From: Steven Sacks Date: Wed, 18 Sep 2024 02:52:24 +0900 Subject: [PATCH 2/2] fix: remove pnpm --- .github/workflows/chromatic.yml | 1 - package-lock.json | 24 ++++++++++++------------ package.json | 2 +- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml index 3455be9..3832fe3 100644 --- a/.github/workflows/chromatic.yml +++ b/.github/workflows/chromatic.yml @@ -31,7 +31,6 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} - debug: true exitZeroOnChanges: true exitOnceUploaded: true autoAcceptChanges: 'main' diff --git a/package-lock.json b/package-lock.json index b4e6109..4be589c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -117,7 +117,7 @@ "husky": "9.1.6", "is-ci": "3.0.1", "lint-staged": "15.2.10", - "msw": "^2.4.2", + "msw": "2.4.2", "postcss": "8.4.47", "postcss-import": "16.1.0", "prettier": "3.3.3", @@ -6670,27 +6670,27 @@ "license": "MIT" }, "node_modules/@rvf/core": { - "version": "6.1.3", - "resolved": "https://registry.npmjs.org/@rvf/core/-/core-6.1.3.tgz", - "integrity": "sha512-0RSEj3F95t54C9FEPw0Go38KzkTQ6HihNqrFb59dt0Y6HZn3gtnwEPi7zwVGqPmEs7oCNdBRelBgEdg2VYV3sQ==", + "version": "6.1.4", + "resolved": "https://registry.npmjs.org/@rvf/core/-/core-6.1.4.tgz", + "integrity": "sha512-sViRtsw7rSKT9duxiwmo+7NmowQMrJsV5noOc24sEiv/P6Ru1iDd6VVVWgZZGB0asapvqA8wzFj2lLyHnPMuLg==", "license": "MIT", "peer": true, "dependencies": { "immer": "^10.0.4" }, "peerDependencies": { - "@rvf/set-get": ">= 0.0.0 < 7.0.0", + "@rvf/set-get": ">= 6.0.3 < 7.0.0", "react": "^17.0.2 || ^18.0.0" } }, "node_modules/@rvf/react": { - "version": "6.1.3", - "resolved": "https://registry.npmjs.org/@rvf/react/-/react-6.1.3.tgz", - "integrity": "sha512-ZWBtjcQsbhO8imCaC/ICrDWzsqJDejcooqrYVhEyTxMhUjKwZfQJ4FvZn3FvOJq9WHTZ3J/W8j6gAWGbsDp9rQ==", + "version": "6.1.4", + "resolved": "https://registry.npmjs.org/@rvf/react/-/react-6.1.4.tgz", + "integrity": "sha512-aEtctNO93n8qh3l5wIMgnGxaJ73V+byTEaa+VDAckzSv8jgiiHx06kBrqXDiunKt8R6zKLaqSygVZssQnX7SCw==", "license": "MIT", "peerDependencies": { "@rvf/core": ">= 6.1.2 < 7.0.0", - "@rvf/set-get": ">= 6.0.1 < 7.0.0", + "@rvf/set-get": ">= 6.0.3 < 7.0.0", "react": "^17.0.2 || ^18.0.0", "react-dom": "^17.0.2 || ^18.0.0" } @@ -6711,9 +6711,9 @@ } }, "node_modules/@rvf/set-get": { - "version": "6.0.2", - "resolved": "https://registry.npmjs.org/@rvf/set-get/-/set-get-6.0.2.tgz", - "integrity": "sha512-tinbHknyAw8kDrMcOFD4DU8Lf1Qb8uuzjaqoeMhZR1kaU3sq+yyPgOYmLhr5VWYNgv7U8zcMZJ79vSrQ0ffn9w==", + "version": "6.0.3", + "resolved": "https://registry.npmjs.org/@rvf/set-get/-/set-get-6.0.3.tgz", + "integrity": "sha512-nv9r1Kr+eRaE9+e50atTqbNmobY7EiTGfh7OlDXyWe71nFK9XsQ3K4Tq1J/FsjrzhBGzGUGwLRxGd8/mxv+i6Q==", "license": "MIT", "peer": true }, diff --git a/package.json b/package.json index 65b2b24..e7d6df0 100644 --- a/package.json +++ b/package.json @@ -135,7 +135,7 @@ "husky": "9.1.6", "is-ci": "3.0.1", "lint-staged": "15.2.10", - "msw": "^2.4.2", + "msw": "2.4.2", "postcss": "8.4.47", "postcss-import": "16.1.0", "prettier": "3.3.3",