You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gajus
merged 1 commit into
gajus:master
from
epoberezkin:epoberezkin/ajv-v7Jan 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch to ajv v7 - now it compiles both schemas to one file with 2 exports - it reduced the size of compiled code (there is a big shared part) and simplified the code on the call site a bit.
refactored schemas to extract shared part. It didn't affect compiled code size - I thought it would - as ajv was already re-using code from duplicated schemas, but I kept it anyway, the schemas are smaller this way - easier to change if needed.
js-beautify is no longer included in ajv-pack (there is no ajv-pack too, standalone code generation is included in ajv now), so it is imported directly to format code. It is not necessary, strictly speaking, maybe the compiled code could be just one big string - let me know.
Should it be a major version upgrade? There is no API changes here, but eslint etc. would have 2 different ajv versions in the tree if it's not - not sure if it may cause any conflicts? It is probably worth releasing as minor version and roll-back if there are any unresolvable conflicts.
In any case please hold it until Ajv v7 is released as main version.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gajus please have a look.
The changes are:
Should it be a major version upgrade? There is no API changes here, but eslint etc. would have 2 different ajv versions in the tree if it's not - not sure if it may cause any conflicts? It is probably worth releasing as minor version and roll-back if there are any unresolvable conflicts.
In any case please hold it until Ajv v7 is released as main version.