Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SpriteRenderer bounding box error #1425

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Fix SpriteRenderer bounding box error #1425

merged 4 commits into from
Mar 21, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

When the width and height of SpriteRenderer are undefined, the texture of Sprite will affect the position of SpriteRenderer.

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Mar 21, 2023
@GuoLei1990 GuoLei1990 merged commit ecce3a3 into galacean:main Mar 21, 2023
@GuoLei1990 GuoLei1990 added the sprite 2D Sprite label Mar 21, 2023
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 30, 2023
@GuoLei1990
Merge branch 'main' into cr/fix-vao
0726a72 
* main: (514 commits)
  "v0.9.0-beta.73"
  fix: scene parser error (galacean#1426)
  Fix SpriteRenderer bounding box error (galacean#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (galacean#1414)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  "v0.9.0-beta.66"
  ...
GuoLei1990 added a commit that referenced this pull request Mar 30, 2023
@GuoLei1990
Merge branch 'main' into dev/1.0
78484d5 
* main:
  Fix `Mesh` change IndexBuffer、VertexBuffer、VertexElements bug( need to update VAO) (#719)
  "v0.9.0-beta.73"
  fix: scene parser error (#1426)
  Fix SpriteRenderer bounding box error (#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (#1414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@singlecoder singlecoder Awaiting requested review from singlecoder

Assignees
No one assigned
Labels
bug Something isn't working sprite 2D Sprite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cptbtptpbcptdtptp @GuoLei1990