Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scene parser error #1426

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

As developers we usually think:

engine.resourceManager.load<Scene>( { url: XXX,  type: XXX } ).then(()=>{
      // At this time we think the scene should have been initialized.
})

But after the scene is loaded, some properties are not initialized.(Like _parseComponents)

@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Mar 22, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 1.0 milestone Mar 22, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Mar 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -1.15 ⚠️

Comparison is base (ecce3a3) 41.95% compared to head (2a64565) 40.81%.

❗ Current head 2a64565 differs from pull request most recent head ddbcc15. Consider uploading reports for the commit ddbcc15 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   41.95%   40.81%   -1.15%     
==========================================
  Files         350      350              
  Lines       17798    17801       +3     
  Branches     2598     2598              
==========================================
- Hits         7468     7265     -203     
- Misses       9647     9895     +248     
+ Partials      683      641      -42     
Impacted Files Coverage Δ
...esource-deserialize/resources/scene/SceneParser.ts 10.34% <50.00%> (-0.57%) ⬇️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Mar 23, 2023
@GuoLei1990 GuoLei1990 merged commit cf638c9 into galacean:main Mar 23, 2023
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 30, 2023
* main: (514 commits)
  "v0.9.0-beta.73"
  fix: scene parser error (galacean#1426)
  Fix SpriteRenderer bounding box error (galacean#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (galacean#1414)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  "v0.9.0-beta.66"
  ...
GuoLei1990 added a commit that referenced this pull request Mar 30, 2023
* main:
  Fix `Mesh` change IndexBuffer、VertexBuffer、VertexElements bug( need to update VAO) (#719)
  "v0.9.0-beta.73"
  fix: scene parser error (#1426)
  Fix SpriteRenderer bounding box error (#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (#1414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants