Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fermikit: avoid writing to inputdir #4105

Closed
wants to merge 3 commits into from

Conversation

pavanvidem
Copy link
Member

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the tool version.

According to #3991 there are two fermi related tools writng to the input dir

  • fermi2 .dat.fai
  • fermikit_variants .dat.fai

@pavanvidem
Copy link
Member Author

fermi2 does not take any FASTA input to generate an index file. I tested it on my local Galaxy instance there was no .fai generated. Can you please check again if it is true?

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Oct 22, 2021

This is the files dir after the planemo test ran (not on your branch .. but the current master):

tree /tmp/tmp95f1wuat/files/
/tmp/tmp95f1wuat/files/
├── 3
│   └── 1
│       └── a
│           └── dataset_31af8b95-c287-4943-904f-21255c8da5b3.dat
├── 4
│   └── 3
│       └── d
│           └── dataset_43dc1578-7d1d-4d6f-8069-48b76cf964ca.dat
├── 8
│   └── a
│       └── f
│           └── dataset_8af2c39a-323c-4f0c-b6ac-e26c2da79a00.dat
├── 9
│   ├── c
│   │   └── d
│   │       └── dataset_9cd20b5f-73cd-46c9-b396-6ecaf5cb9497.dat
│   └── d
│       └── 5
│           ├── dataset_9d5b6381-6a77-4006-b8db-0a3158bcf3d5.dat
│           └── dataset_9d5b6381-6a77-4006-b8db-0a3158bcf3d5.dat.fai
├── d
│   └── 7
│       └── d
│           └── dataset_d7df0b0c-9363-4630-847d-42d34196b14d.dat
└── _metadata_files
    └── 3
        └── d
            └── d
                └── metadata_3dd1b444-14dd-4528-908d-f02f1b80f68f.dat

I guess its coming from this call
htsbox abreak -bcuf '/tmp/tmp95f1wuat/files/9/d/5/dataset_9d5b6381-6a77-4006-b8db-0a3158bcf3d5.dat'

@pavanvidem
Copy link
Member Author

htsbox abreak -bcuf $ref call exits only in fermikit_variants tool, not in fermi2. In that case, it should be fixed in this PR.

We had a small discussion on silent update here: #3951 (comment)

#import re
#set escaped_element_identifier = re.sub('[^\w\-\s]', '_', str($bam.element_identifier))
#set ref = $reference_genome.fasta_item.fields.path if $reference_genome.reference_genome_source == "reference" else $reference_genome.history_item
#set ref = $reference_genome.fasta_item.fields.path if $reference_genome.reference_genome_source == "reference" else 'reference.fa'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the tool also wring to the locations specified in the data table?

@bernt-matthias
Copy link
Contributor

When checking the diff it seems that this PR has been implemented meanwhile. Closing this.

@pavanvidem pavanvidem deleted the fermi-input-fix branch July 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants