-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fermikit: avoid writing to inputdir #4105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the tool version.
According to #3991 there are two fermi related tools writng to the input dir
- fermi2 .dat.fai
- fermikit_variants .dat.fai
fermi2 does not take any FASTA input to generate an index file. I tested it on my local Galaxy instance there was no |
This is the files dir after the planemo test ran (not on your branch .. but the current master):
I guess its coming from this call |
We had a small discussion on silent update here: #3951 (comment) |
#import re | ||
#set escaped_element_identifier = re.sub('[^\w\-\s]', '_', str($bam.element_identifier)) | ||
#set ref = $reference_genome.fasta_item.fields.path if $reference_genome.reference_genome_source == "reference" else $reference_genome.history_item | ||
#set ref = $reference_genome.fasta_item.fields.path if $reference_genome.reference_genome_source == "reference" else 'reference.fa' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the tool also wring to the locations specified in the data table?
When checking the diff it seems that this PR has been implemented meanwhile. Closing this. |
FOR CONTRIBUTOR: