Fix: Incorrect Implementation of View Pass Handler #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eye icon (view pass) handler for the
Input
element secure text entry is not implemented correctly. The eye icon toggle is supposed to toggle between thesecureTextEntry
values of the password text input property, but it does not do that right now.Current Bug:
Note
setIsPassword(password)
does not actually do anything since the password property is always true for password fields.Solution in PR:
The solution is to toggle the
isPassword
flag instead.