Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the contribution guide and code of conduct's relative paths #471

Closed
wants to merge 2 commits into from

Conversation

EricRibeiro
Copy link
Member

Changes

  • Replace relative links with their full path equivalent

Relative links do not work in pull requests. Support was requested here, but the feature was never implemented. More information can be found here.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #471 (59fd1e2) into main (5bd589e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   36.65%   36.65%           
=======================================
  Files          72       72           
  Lines        2736     2736           
  Branches      507      507           
=======================================
  Hits         1003     1003           
  Misses       1731     1731           
  Partials        2        2           

@EricRibeiro EricRibeiro changed the title chore: hard code links in the pull request template chore: fix the contribution guide and code of conduct's relative paths Oct 31, 2022
@webbertakken
Copy link
Member

Please see the discussion in this PR game-ci/cli#31

@davidmfinol
Copy link
Member

Done by #505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants