From ed77ebcabae566c795fcc55c2c7c84908097d4fa Mon Sep 17 00:00:00 2001 From: Friedrich Rober Date: Tue, 13 Feb 2024 11:00:50 +0100 Subject: [PATCH 1/3] Remove TODOs from Doc --- doc/lins_search.xml | 29 ++--------------------------- 1 file changed, 2 insertions(+), 27 deletions(-) diff --git a/doc/lins_search.xml b/doc/lins_search.xml index 5547f99..9cccb07 100644 --- a/doc/lins_search.xml +++ b/doc/lins_search.xml @@ -1,23 +1,9 @@ LINS Search -This chapter is for advanced users and those interested in a brief introduction to the mathematical background of &LINS;. +This chapter is for advanced users and those interested in a brief introduction to the mathematical background of &LINS;.

-

-LINS Search Strategy - -In this section, we briefly introduce the basic search strategy for normal subgroups.

- -TODO - -

- -
-LINS Target Tables - -TODO - -
+(NOTE: The internal options below might change during further development!)
LINS Search Options @@ -118,15 +104,4 @@ with elementary abelian p-quotient in rH should be computed.
-
-LINS Custom Search Functions - -In this section we explain how to write a custom search function by using the options for LowIndexNormalSubgroupsSearch.

- -We explain this on the example of LowIndexNormalSubgroupsSearchForIndex.

- -TODO - -

- From d1142e3867d104e043fc9677f399a310590977d9 Mon Sep 17 00:00:00 2001 From: Friedrich Rober Date: Tue, 12 Mar 2024 18:23:41 +0100 Subject: [PATCH 2/3] Add References --- doc/LINS.bib | 7 +++++++ doc/intro.xml | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 doc/LINS.bib diff --git a/doc/LINS.bib b/doc/LINS.bib new file mode 100644 index 0000000..dd05d64 --- /dev/null +++ b/doc/LINS.bib @@ -0,0 +1,7 @@ +@phdthesis{Firth, + type = {Ph.D. thesis}, + author = {David Firth}, + school = {University of Warwick}, + title = {An Algorithm to Find Normal Subgroups of a Finitely Presented Group, up to a Given Finite Index}, + year = {2005}, +} diff --git a/doc/intro.xml b/doc/intro.xml index a171197..4fdad91 100644 --- a/doc/intro.xml +++ b/doc/intro.xml @@ -11,8 +11,9 @@ The package &LINS; provides an algorithm for computing the normal subgroups of a Moreover it provides an interface for searching in the normal subgroup lattice of a finitely presented group. For example, one can use this interface to search for l normal subgroups of index n.

-The algorithm is based on work of Derek Holt and David Firth. -They have implemented this algorithm in the algebra software MAGMA.

+The algorithm is based on work of David Firth . +He implemented that algorithm in the algebra software MAGMA. +That implementation in MAGMA has been revised and rewritten to a great extent by Derek Holt.

The current implementation in ⪆ uses a table of groups that was computed by the code in createTables.gi. From 7fca603e4fb1ad356875a610e49eeaf01c0bd4a8 Mon Sep 17 00:00:00 2001 From: Friedrich Rober Date: Wed, 13 Mar 2024 12:07:23 +0100 Subject: [PATCH 3/3] doc: fix typo --- gap/LINS.gd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gap/LINS.gd b/gap/LINS.gd index 6f510a1..c7dec43 100644 --- a/gap/LINS.gd +++ b/gap/LINS.gd @@ -181,7 +181,7 @@ DeclareAttribute( "LinsOptions", IsLinsGraph, "mutable" ); ## ## Returns a list of all normal subgroups of G with index at most n. ## If the option allSubgroups is set to false, -## then onlye the normal subgroups of G with index equal to n are returned.

+## then only the normal subgroups of G with index equal to n are returned.

## ## The generic method uses to transform G into an fp-group ## and then calls some variant of the low-level function .